fix(server): handle null key string in utils (check_null_key) #789
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Ensure that the `shorten_key` function in `utils.py` returns the key string itself when it is null or empty, preventing further processing that could lead to errors.
cpacker
approved these changes
Jan 11, 2024
|
Thank you! |
mattzh72
pushed a commit
that referenced
this pull request
Oct 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ensure that the
shorten_keyfunction inutils.pyreturns the key string itself when it is null or empty, preventing further processing that could lead to errors.Please describe the purpose of this pull request.
Is it to add a new feature? Is it to fix a bug?
to fix a bug
How to test
How can we test your PR during review? What commands should we run? What outcomes should we expect?
use server endpoint GET
/configif one of the 'key' values is not set (e.g. 'azure_key')Have you tested this PR?
Have you tested the latest commit on the PR? If so please provide outputs from your tests.
I tested the endpoint, the result was the system's config
Related issues or PRs
Please link any related GitHub issues or PRs.
Is your PR over 500 lines of code?
If so, please break up your PR into multiple smaller PRs so that we can review them quickly, or provide justification for its length.
no
Additional context
Add any other context or screenshots about the PR here.