fix: patch bug on TEI embedding lookup #724
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please describe the purpose of this pull request.
Same bug we patched before with having to unpack TEI embedding payload. However, I noticed that in LocalIndex the embeddings on a query get created again, so our previous patch doesn't apply, and thus we get a similar error. This patch uses QueryBundle to make sure we don't create another embedding on query, so that we don't have another unpacking problem.
How to test
Use
memgpt quickstart
On main, ask "insert "banana" into archival memory", then "search archival memory for "banana"" and you'll get this error:
With this PR, you won't get the error:
Have you tested this PR?
Yes, using memgpt quickstart.