-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: added basic heartbeat override heuristics #621
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ng in latest lmstudio build
cpacker
changed the title
added basic heartbeat override heuristics
feat: added basic heartbeat override heuristics
Dec 16, 2023
sarahwooders
pushed a commit
that referenced
this pull request
Dec 26, 2023
* added basic heartbeat override * tested and working on lmstudio (patched typo + patched new bug emerging in latest lmstudio build * added lmstudio patch to chatml wrapper * update the system messages to be informative about the source * updated string constants after some tuning
norton120
pushed a commit
to norton120/MemGPT
that referenced
this pull request
Feb 15, 2024
* added basic heartbeat override * tested and working on lmstudio (patched typo + patched new bug emerging in latest lmstudio build * added lmstudio patch to chatml wrapper * update the system messages to be informative about the source * updated string constants after some tuning
mattzh72
pushed a commit
that referenced
this pull request
Oct 9, 2024
* added basic heartbeat override * tested and working on lmstudio (patched typo + patched new bug emerging in latest lmstudio build * added lmstudio patch to chatml wrapper * update the system messages to be informative about the source * updated string constants after some tuning
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #601
Please describe the purpose of this pull request.
Local/open LLMs can often forget to request a heartbeat when running functions. E.g.:
This PR adds a basic heuristics to manually insert the heartbeat request:
type == user_message
), and the agent immediately runs a function (non-send-message function), 99% chance the user is expecting a replyHow to test
pytest -s -vvv tests/test_function_parser.py
)Have you tested this PR?
Yes, see below.
Side note: had to patch a new bug in LM Studio where the prefix is no longer adhered to (probably to do with their default prompt formatting changing?), which requires unpacking a nested
function
due to our json patchers: