added ignores for OS, IDE, and Python that were missing. (#446) #447
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
memgpt/constants.py
Outdated
| @@ -1,6 +1,6 @@ | |||
| import os | |||
|
|
|||
| MEMGPT_DIR = os.path.join(os.path.expanduser("~"), ".memgpt") | |||
| MEMGPT_DIR = os.getenv(os.path.join("MEMGPT_CONFIG_PATH",".memgpt"), default=os.path.join(os.path.expanduser("~"), ".memgpt")) | |||
There was a problem hiding this comment.
I think MEMGPT_CONFIG_PATH is currently the actual path of the config? so ~/.memgpt/config, rather than the directory.
So this should maybe be:
MEMGPT_DIR = os.getenv("MEMGPT_CONFIG_PATH", default=os.path.join(os.path.expanduser("~"), ".memgpt"))
There was a problem hiding this comment.
The MEMGPT_DIR was not supposed to be included only the one for .gitignore.
|
This is the corrected form.
MEMGPT_DIR = os.getenv(os.path.join("MEMGPT_CONFIG_PATH",
default=os.path.join(os.path.expanduser("~"), ".memgpt"))
…On Wed, Nov 15, 2023 at 6:10 PM Sarah Wooders ***@***.***> wrote:
***@***.**** commented on this pull request.
------------------------------
In memgpt/constants.py
<#447 (comment)>:
> @@ -1,6 +1,6 @@
import os
-MEMGPT_DIR = os.path.join(os.path.expanduser("~"), ".memgpt")
+MEMGPT_DIR = os.getenv(os.path.join("MEMGPT_CONFIG_PATH",".memgpt"), default=os.path.join(os.path.expanduser("~"), ".memgpt"))
I think MEMGPT_CONFIG_PATH is currently the actual path of the config? so
~/.memgpt/config, rather than the directory.
So this should maybe be:
MEMGPT_DIR = os.getenv("MEMGPT_CONFIG_PATH", default=os.path.join(os.path.expanduser("~"), ".memgpt"))
—
Reply to this email directly, view it on GitHub
<#447 (review)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AE4N3TRFREULKNJJA7CA5PDYEVDXRAVCNFSM6AAAAAA7LKOUPGVHI2DSMVQWIX3LMV43YUDVNRWFEZLROVSXG5CSMV3GSZLXHMYTOMZTGIYDAMJUGE>
.
You are receiving this because you authored the thread.Message ID:
***@***.***>
|
|
@agiletechnologist could you remove the |
agiletechnologist
force-pushed
the
develop
branch
from
403dad6 to
093df8b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please describe the purpose of this pull request.
This is a fix for #446
How to test
This is for ignoring git commits for Python, OS, and IDE's
Have you tested this PR?
Yes. There are some files to be removed but will not be ignored until removed. Will discuss the removal.
Is your PR over 500 lines of code?
Yes but one file. makes more sense as a single pull.