feat: Improve retry mechanism for _get_ai_reply and refactor method
#2113
+45
−44
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mattzh72
had a problem deploying
to
Deployment
GitHub Actions
Failure
mattzh72
had a problem deploying
to
Deployment
GitHub Actions
Failure
mattzh72
had a problem deploying
to
Deployment
GitHub Actions
Failure
mattzh72
had a problem deploying
to
Deployment
GitHub Actions
Failure
| if response.choices[0].finish_reason not in ["stop", "function_call", "tool_calls"]: | ||
| if response.choices[0].finish_reason == "length": | ||
| # This is not retryable, hence RuntimeError v.s. ValueError | ||
| raise RuntimeError("Finish reason was length (maximum context length)") |
There was a problem hiding this comment.
will this get caught by the summarizer?
There was a problem hiding this comment.
Seems to pass summarizer tests though
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Improve retry mechanism for
_get_ai_replyand refactor method to improve code quality. We add an exponential backoff, and differentiate between retryable errors v.s. generic errors.Testing
Rely on existing unit testing.