fix: Fix Azure provider and add complex e2e testing #1842
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sarahwooders
reviewed
Oct 8, 2024
sarahwooders
reviewed
Oct 8, 2024
added 2 commits
October 7, 2024 17:26
sarahwooders
reviewed
Oct 8, 2024
sarahwooders
approved these changes
Oct 8, 2024
mattzh72
added a commit
that referenced
this pull request
Oct 9, 2024
Co-authored-by: Matt Zhou <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fix Azure endpoint and add complex e2e testing. Originally, Azure endpoint was broken. We fixed this by factoring out the logic written for the OpenAI provider and extending it the Azure provider.
Variety of other changes as well:
testsdirectory to make clear configs are only used for testinginner_thoughts_in_kwargsTesting
Wrote testing suite in
test_endpoints.pyand manually ran them. Holding off on adding this to CI for now because we need @cpacker to add environment variables into GH Actions.