fix: static files mounting bug #1746
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cpacker
commented
Sep 10, 2024
| @@ -58,29 +55,6 @@ | |||
| OPENAI_API_PREFIX = "/openai" | |||
|
|
|||
|
|
|||
| class SmartStaticFilesMiddleware(BaseHTTPMiddleware): | |||
There was a problem hiding this comment.
note @4shub here's the cleanup
cpacker
commented
Sep 10, 2024
| @@ -123,7 +95,7 @@ def create_application() -> "FastAPI": | |||
| app.include_router(setup_auth_router(server, interface, password), prefix=API_PREFIX) | |||
|
|
|||
| # / static files | |||
| # mount_static_files(app) | |||
| mount_static_files(app) | |||
There was a problem hiding this comment.
This line causes unit tests to fail, but without it we lose the SPA
mattzh72
pushed a commit
that referenced
this pull request
Oct 9, 2024
Co-authored-by: Shubham Naik <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
tldr of bug is:
To check if the website is working:
memgpt serverthenlocalhost:8283should spawn the SPATo check if the RESTClient unit tests are working, run
pytest -s -vvv tests/test_client.py::test_agent