-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor: use jinja2
templates for Memory.compile
instead of writing Python code
#1687
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…r__, (2) migrate recall and archival memory to also not overload __repr__
cpacker
commented
Aug 27, 2024
cpacker
commented
Aug 27, 2024
cpacker
commented
Aug 27, 2024
Memory.compile
instead of writing Python codejinja2
templates for Memory.compile
instead of writing Python code
…it's backwards compatible
…) return a nested dictionary instead of a flat dictionary
Maybe rename |
cpacker
commented
Sep 3, 2024
sarahwooders
reviewed
Sep 3, 2024
sarahwooders
reviewed
Sep 3, 2024
sarahwooders
approved these changes
Sep 3, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Additions
Memory
to a non-overloaded function #1683 toRecallMemory
andArchivalMemory
(previous PR only didCoreMemory
)compile
code inCoreMemory
to usejinja2
instead of having a Python loopRe: (2) - this should make it much more straight forward to allow changing the way the 'prompt formatting' of the memory object when creating custom memory blocks on the dev portal, since the back-and-forth between the frontend and backend will be a
jinja2
template string, instead of Python code that needs to be interpreted.TODO
Testing
Added test to double-check that the new
jinja2
template is equivalent to the old Python__repr__
code:Added test for a
Memory.set_template
function that validates if the template string is valid or not (is it goodjinja2
+ does it compile?)