Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Fix CLI agent delete functionality & allow importation of file for system prompt - attempt #2 #1607

Merged
merged 6 commits into from
Aug 4, 2024

Conversation

madgrizzle
Copy link
Contributor

Please describe the purpose of this pull request.
I should learn how to use git better..

Changes the cli_config.py broke the delete agent functionality. LocalClient.delete_agent() expects an agent id to be provided but code provides the agent name.
Adds code to allow a text file to be used to import the system prompt from memgpt run for use in new agent creation.
How to test

Try to delete an agent without change. LocalClient will respond back with:
LocalClient.delete_agent() got an unexpected keyword argument 'agent_name'
Apply fix and try again.

memgpt run --system-file
Will load the text file during new agent creation.

Have you tested this PR?
Yes, it works.

Related issues or PRs
Please link any related GitHub issues or PRs.

Is your PR over 500 lines of code?
Nope

Additional context
Not really.

@sarahwooders sarahwooders self-requested a review August 4, 2024 04:20
Copy link
Collaborator

@sarahwooders sarahwooders left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm - thank you!

@sarahwooders sarahwooders merged commit a032815 into letta-ai:main Aug 4, 2024
9 of 11 checks passed
mattzh72 pushed a commit that referenced this pull request Oct 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants