Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: update quickstart-server instructions #1409

Merged
merged 2 commits into from
May 25, 2024

Conversation

MEllis-github
Copy link
Contributor

@MEllis-github MEllis-github commented May 24, 2024

Please describe the purpose of this pull request.
Is it to add a new feature? Is it to fix a bug?

When following the server quickstart instructions as is, $ docker compose up yields the following due to .env not being included in the repo except in the form of env.example. (Not a great out-of-the-box experience.) This PR adds a simple step on managing .env. It's not clear this is the best way to handle this, but at least takes care of the warnings and fatal error.

WARN[0000] The "MEMGPT_PG_USER" variable is not set. Defaulting to a blank string. 
WARN[0000] The "MEMGPT_PG_PASSWORD" variable is not set. Defaulting to a blank string. 
WARN[0000] The "MEMGPT_PG_DB" variable is not set. Defaulting to a blank string. 
WARN[0000] The "MEMGPT_SERVER_PASS" variable is not set. Defaulting to a blank string. 
WARN[0000] The "MEMGPT_PG_DB" variable is not set. Defaulting to a blank string. 
WARN[0000] The "MEMGPT_PG_USER" variable is not set. Defaulting to a blank string. 
WARN[0000] The "MEMGPT_PG_PASSWORD" variable is not set. Defaulting to a blank string. 
WARN[0000] The "OPENAI_API_KEY" variable is not set. Defaulting to a blank string. 
WARN[0000] The "MEMGPT_PG_USER" variable is not set. Defaulting to a blank string. 
WARN[0000] The "MEMGPT_PG_PASSWORD" variable is not set. Defaulting to a blank string. 
WARN[0000] The "MEMGPT_PG_DB" variable is not set. Defaulting to a blank string. 
env file /Users/mme/Documents/GitHub/MemGPT/.env not found: stat /Users/mme/Documents/GitHub/MemGPT/.env: no such file or directory

How to test
How can we test your PR during review? What commands should we run? What outcomes should we expect?

Run the server-quick start steps. docker compose up should start the server as intended.

Have you tested this PR?
Have you tested the latest commit on the PR? If so please provide outputs from your tests.

Yes, following the steps produced the intended result of the original quickstart instructions.

Related issues or PRs
Please link any related GitHub issues or PRs.

Is your PR over 500 lines of code?
If so, please break up your PR into multiple smaller PRs so that we can review them quickly, or provide justification for its length.

No

Additional context
Add any other context or screenshots about the PR here.

@MEllis-github MEllis-github marked this pull request as ready for review May 24, 2024 22:12
@cpacker cpacker requested a review from sarahwooders May 24, 2024 22:41
Copy link
Collaborator

@sarahwooders sarahwooders left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm! thank you so much!

@sarahwooders sarahwooders merged commit 3ae5bc5 into letta-ai:main May 25, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants