Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Failing CI tests on external PRs #1090

Closed
cpacker opened this issue Mar 5, 2024 · 0 comments · Fixed by #1096
Closed

Failing CI tests on external PRs #1090

cpacker opened this issue Mar 5, 2024 · 0 comments · Fixed by #1096
Assignees
@cpacker
Labels
bug Something isn't working

Comments

@cpacker
Copy link
Collaborator

cpacker commented Mar 5, 2024

Describe the bug

  • Contributor PRs are failing at the review stage but passing once merged into main
  • This is because github actions is being run via the hosted service on external PRs, vs on OpenAI API for main branch tests
  • However for some reason we're getting OAI connection errors on the external PRs, meaning that OAI is being run for some reason when it shouldn't be (should be local or hosted, but not OAI)

image
@cpacker cpacker added the bug Something isn't working label Mar 5, 2024
@cpacker cpacker self-assigned this Mar 5, 2024
@cpacker cpacker changed the title Fix failing CI tests on external PRs Failing CI tests on external PRs Mar 5, 2024
@cpacker cpacker moved this from To triage to Ready in 🐛 MemGPT issue tracker Mar 5, 2024
@cpacker cpacker mentioned this issue Mar 5, 2024
Merged
@github-project-automation github-project-automation bot moved this from Ready to Done in 🐛 MemGPT issue tracker Mar 5, 2024
sarahwooders pushed a commit that referenced this issue Feb 21, 2025
@carenthomas
chore: add user id header to identities get request (#1090)
0d9ff8a
sarahwooders added a commit that referenced this issue Feb 21, 2025
@sarahwooders
chore: add user id header to identities get request (#1090) (#2448)
3cfc1a7
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@cpacker cpacker

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

ci: patch embedding issue in tests letta-ai/letta
1 participant
@cpacker