Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update plotly-min.js #954

Merged
merged 2 commits into from
Feb 23, 2020
Merged

Update plotly-min.js #954

merged 2 commits into from
Feb 23, 2020

Conversation

tdelmas
Copy link
Collaborator

@tdelmas tdelmas commented Feb 16, 2020

From v1.48.3 to v1.52.2 and downgrade from full to basic (to avoid plotly/plotly.js#897 and reduce size)

If Google Analytics is also removed in the future, it will allow to use a more strict CSP without unsafe-eval for script-src

From v1.48.3 to v1.52.2 and downgrade from full to basic (to avoid plotly/plotly.js#897)
@tdelmas tdelmas marked this pull request as ready for review February 16, 2020 22:14
@bdaehlie
Copy link
Collaborator

Fine with me if we're not losing anything in the downgrade from full to basic.

@tdelmas
Copy link
Collaborator Author

tdelmas commented Feb 18, 2020

The documentation about Plotly basic: https://github.com/plotly/plotly.js/tree/master/dist#plotlyjs-basic
I'm confident we are not loosing functionality, and manual testing didn't show any difference.

TODO: Allow blob: for image-src to allow Plotly image capture (it is working with the previous version)

@tdelmas tdelmas changed the title Update plotly-min.js [WIP] Update plotly-min.js Feb 18, 2020
@tdelmas tdelmas changed the title [WIP] Update plotly-min.js Update plotly-min.js Feb 19, 2020
@tdelmas
Copy link
Collaborator Author

tdelmas commented Feb 21, 2020

@andygabby just for information: It updates the CSP to allow blob: for image-src to allow Plotly image capture.

@tdelmas tdelmas merged commit 4f99e26 into letsencrypt:master Feb 23, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants