Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build(deps): bump github.com/google/certificate-transparency-go from 1.1.4 to 1.1.6 #6975

Conversation

dependabot[bot]
Copy link
Contributor

@dependabot dependabot bot commented on behalf of github Jul 5, 2023

Update google/certificate-transparency-go from 1.1.4 to 1.1.6
Release notes: https://github.com/google/certificate-transparency-go/releases/tag/v1.1.6
Changelog: google/certificate-transparency-go@v1.1.4...v1.1.6

Update prometheus/client_golang from v1.14.0 to v1.15.1
Release notes: https://github.com/prometheus/client_golang/releases/tag/v1.15.1
Changelog: prometheus/client_golang@v1.14.0...v1.15.1

Update prometheus/client_model from v0.3.0 to v0.4.0
Release notes: https://github.com/prometheus/client_model/releases/tag/v0.4.0
Changelog: prometheus/client_model@v0.3.0...v0.4.0

Update x/sync from v0.1.0 to v0.2.0
Changelog: golang/sync@v0.1.0...v0.2.0

Minor updates to various indirect dependencies as well.

The prometheus/client_golang update changes the type of prometheus.Desc.variableLabels from []string to prometheus.ConstrainedLabels, which changes the string representation of that field, necessitating a minor test expectations update in //rocsp/metrics_test.

Fixes #4548

@dependabot dependabot bot requested a review from a team as a code owner July 5, 2023 01:58
@dependabot dependabot bot requested a review from aarongable July 5, 2023 01:58
@dependabot dependabot bot added dependencies Pull requests that update a dependency file go Pull requests that update Go code labels Jul 5, 2023
@aarongable
Copy link
Contributor

We definitely want this update: getting the v1.1.5 public/private key consistency improvements that came out of a CT incident a few months ago is a really good idea.

However, this update also transitively updates go-sql-driver, which is a very dangerous change for us. We need to update that dependency independently before this one can land. Unfortunately, even updating ctgo to just v1.1.5 also brings in that transitive update.

I've filed #6976 and then we can return to this one.
Nota bene: this PR, if it lands, will also resolve #4548

@dependabot dependabot bot force-pushed the dependabot/go_modules/github.com/google/certificate-transparency-go-1.1.6 branch 2 times, most recently from f63fe11 to b2fd3e2 Compare July 11, 2023 19:52
@dependabot dependabot bot force-pushed the dependabot/go_modules/github.com/google/certificate-transparency-go-1.1.6 branch from b2fd3e2 to 9cdd7e3 Compare July 17, 2023 21:39
Bumps [github.com/google/certificate-transparency-go](https://github.com/google/certificate-transparency-go) from 1.1.4 to 1.1.6.
- [Release notes](https://github.com/google/certificate-transparency-go/releases)
- [Changelog](https://github.com/google/certificate-transparency-go/blob/master/CHANGELOG.md)
- [Commits](google/certificate-transparency-go@v1.1.4...v1.1.6)

---
updated-dependencies:
- dependency-name: github.com/google/certificate-transparency-go
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <[email protected]>
@dependabot dependabot bot force-pushed the dependabot/go_modules/github.com/google/certificate-transparency-go-1.1.6 branch from 9cdd7e3 to 12fb6df Compare July 20, 2023 19:29
@pgporada
Copy link
Member

Due to go.mod exclusions, there's no longer a go-sql-driver/mysql upgrade included in this PR.

@aarongable aarongable merged commit 75acd40 into main Jul 21, 2023
@aarongable aarongable deleted the dependabot/go_modules/github.com/google/certificate-transparency-go-1.1.6 branch July 21, 2023 18:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file go Pull requests that update Go code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update certificate-transparency-go to latest commit
2 participants