Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

MPIC: require non-empty perspective and RIR fields #7819

Open
jsha opened this issue Nov 15, 2024 · 1 comment
Open

MPIC: require non-empty perspective and RIR fields #7819

jsha opened this issue Nov 15, 2024 · 1 comment
Assignees
@beautifulentropy
Milestone
Sprint 2024-12-10

Comments

@jsha
Copy link
Contributor

jsha commented Nov 15, 2024

Discussed in #7817 (comment) and at standup.

It's useful for the the primary VA to know what its backend perspectives are. It can check at startup that all its perspectives are distinct. And it can log errors by perspective even when those errors are due to a perspective being down.

However, there's a risk that the primary VA could be configured wrong: it could think a given backend is perspective A, when actually it's perspective B. In fact, a given SRV record could mistakenly resolve to a pool of backends with some in perspective A and some in perspective B!

We can add some double-checking here. We should have the primary know which perspective each of its backends is in, and assert that in each RPC. The backends (remotes) should also know what perspective it considers itself to be in. They can check the asserted perspective against the locally configured perspective, and return an error if there is a mismatch.
@aarongable aarongable added this to the Sprint 2024-11-19 milestone Nov 19, 2024
This was referenced Nov 21, 2024
Merged
Merged
beautifulentropy added a commit that referenced this issue Nov 25, 2024
@beautifulentropy
va: Make the primary VA aware of the Perspective and RIR of each remo…
c394831 
…te (#7839)

- Make the primary VA aware of the expected Perspective and RIR of each
remote VA.
- All Perspectives should be unique, have the primary VA check for
duplicate Perspectives at startup.
- Update test setup functions to ensure that each remote VA client and
corresponding inmem impl have a matching perspective and RIR.

Part of #7819
beautifulentropy added a commit that referenced this issue Dec 6, 2024
@beautifulentropy
va: Check for RIR and Perspective mismatches at runtime when they're …
87104b0 
…provided (#7841)

- Ensure the Perspective and RIR reported by each remoteVA in the
*vapb.ValidationResult returned by VA.PerformValidation, matches the
expected local configuration when that configuration is present.
- Correct "AfriNIC" to "AFRINIC", everywhere.


Part of #7819
beautifulentropy added a commit that referenced this issue Dec 6, 2024
@beautifulentropy
va: Check for RIR and Perspective mismatches at runtime when they're …
4316c7c 
…provided (#7841)

- Ensure the Perspective and RIR reported by each remoteVA in the
*vapb.ValidationResult returned by VA.PerformValidation, matches the
expected local configuration when that configuration is present.
- Correct "AfriNIC" to "AFRINIC", everywhere.

Part of #7819
@aarongable aarongable changed the title MPIC: both primary and remote should know about perspectives MPIC: require non-empty perspective and RIR fields Dec 10, 2024
@aarongable
Copy link
Contributor

Updating this bug to cover the last steps here:

  • making the config fields required
  • removing empty-string carveouts at startup and runtime correspondence checks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@beautifulentropy beautifulentropy

Labels
None yet
Projects
None yet
Milestone
Sprint 2024-12-10
Development

No branches or pull requests
3 participants
@jsha @aarongable @beautifulentropy