-
Notifications
You must be signed in to change notification settings - Fork 3.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: upgrade typescript/eslint related dependencies, drop node8 and add node16 CI support #3628
Conversation
Looks like tests are failing? |
Yes,it's werid. All test passed in my local machine. Try to investigate it. |
https://eslint.org/docs/user-guide/migrating-to-7.0.0#nodejs-8-is-no-longer-supported
I am confused aboute appveyor's node version ! @matthew-dean node --version && npm --version
v8.17.0
6.13.4
cd packages/less && npm test example link: https://ci.appveyor.com/project/lukeapage/less-js/builds/39727397/job/7xcn72bns87m7iw8#L28 There is a long-term bug in our appveyor CI ! Matrix nodejs_version not work actually. You must add install script like follow - ps: Install-Product node $env:nodejs_version otherwise your nodejs_version always be default appveyor nodjs_version (current is node8). If you add install script you will get correct matrix test. Running Install scripts
Install-Product node $env:nodejs_version
Uninstalling node 8.17.0 (x86)...
Installing node 10.24.1 (x86)... https://help.appveyor.com/discussions/questions/11941-node-version-not-available-after-specifying-nodejs_version for more details. |
#3629 (comment) remove appveyor for fast ci.
Fix the
CI
test terminal warningUpgrade list:
Attention !
Don't upgrade rollup-plugin-typescript2 from
0.29.0
to0.30.0
, becaus it throw a compile error when encount npm packagenode_modules/parse-node-version
. (need to investigation and report bug to https://github.com/ezolenko/rollup-plugin-typescript2