Small steps toward making RSI py3 compatible #250
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
timothydmorton
force-pushed
the
rsi-py3
branch
from
b765512
to
092d2b0
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I have found that under python 3, writing to the RSI database breaks with a bytes vs. string issue when pickling, which is fixed if the pickle write/reading is binary (using
'wb'/'rb'). Also, the shape of the data has to be integers, which requires explicit integer division in py3. There are a number of other things that would need to be fixed to make the app fully py3 compatible, as the JSON message writing breaks when trying to write bytes as well, but that seems more involved, so this is just a start to that.