Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Outgoing proxy #68

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Outgoing proxy #68

wants to merge 2 commits into from

Conversation

peske
Copy link

@peske peske commented Jun 9, 2016

http_proxy parameter introduced into kibana4::plugin type. It's actually workaround for elastic/kibana#5902

To explain changes:

  • kibana_plugin_install_proxy.sh file added (downloads the plugin through proxy to /tmp directory, and then executes /opt/kibana/bin/kibana --install to install it.
  • file resource that installs kibana_plugin_install_proxy.sh script is added to install.pp
  • One elsif option is added to plugin.pp that checks if http_proxy is specified, and if it is calls the new script file instead of executing /opt/kibana/bin/kibana --install directly. Other two options are unchanged (only cosmetic change that avoids repetition).

It works - I'm already using it in my environment.

@peske
Copy link
Author

peske commented Jun 10, 2016

Well, I don't know why these checks are failed (maybe because I've added sh script?), but two things I know for sure:

  • The change I've introduced cannot break any existing feature because it doesn't change anything if http_proxy parameter is not provided.
  • Module with the change included works like charm (I'm using it). Here's my script that installs all Kibana modules:
# https://forge.puppet.com/lesaux/kibana4
class { 'kibana4':
  package_repo_version => '4.5', 
  service_ensure       => 'running', 
  service_enable       => true, 
  plugins              => {
    'elastic/timelion' => {
       plugin_dest_dir => 'timelion', 
       ensure          => present, 
       url             => 'https://download.elasticsearch.org/kibana/timelion/timelion-latest.tar.gz', 
       http_proxy      => 'http://internal-proxy.itenlight.com:8080', 
    },
    'sirensolutions/kibi_radar_vis' => {
       plugin_dest_dir => 'kibi_radar_vis', 
       ensure          => present, 
       url             => 'https://github.com/sirensolutions/kibi_radar_vis/archive/0.1.0.zip', 
       http_proxy      => 'http://internal-proxy.itenlight.com:8080', 
    },
    'sirensolutions/kibi_wordcloud_vis' => {
       plugin_dest_dir => 'kibi_wordcloud_vis', 
       ensure          => present, 
       url             => 'https://github.com/sirensolutions/kibi_wordcloud_vis/raw/0.1.0/target/kibi_wordcloud_vis-0.1.0.zip', 
       http_proxy      => 'http://internal-proxy.itenlight.com:8080', 
    },
    'sbeyn/kibana-plugin-gauge-sg' => {
       plugin_dest_dir => 'gauge_sg', 
       ensure          => present, 
       url             => 'https://github.com/sbeyn/kibana-plugin-gauge-sg/archive/master.zip', 
       http_proxy      => 'http://internal-proxy.itenlight.com:8080', 
    },
    'sbeyn/kibana-plugin-traffic-sg' => {
       plugin_dest_dir => 'traffic_sg', 
       ensure          => present, 
       url             => 'https://github.com/sbeyn/kibana-plugin-traffic-sg/archive/master.zip', 
       http_proxy      => 'http://internal-proxy.itenlight.com:8080', 
    },
  }, 
}

@madAndroid
Copy link

@peske - if you look at the output in the Travis links, the puppet-lint tests are failing

@peske
Copy link
Author

peske commented Jun 10, 2016

As I've said - I don't know why. If you have a few minutes you can check what I've changed (except for the added sh script only few puppet lines are changed).

But finally it's up to you.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants