-
Notifications
You must be signed in to change notification settings - Fork 6
Improvements (titles and school adress), correct end times for my school and fixed #41 #39
base: master
Are you sure you want to change the base?
Conversation
…it off of my courses, it may be incomplete/inaccurate for other schools). Please extend the list as you see fit.
…json file and if so it uses that name for the course title.
Alright, what I did is add a small piece of code that allows you to add your school's address. Why is this useful? Well, my phone will now tell me when it's time to leave (Apple does this automatically if there is a location included in the event). The way the location is formatted as following now:
It might be that in order for it to work properly you need to update the string a bit in the |
…a special code block to fix this.
My latest commit fixes issue #41. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Overall some great improvements to this package, thank you Julian.
I've shared some thoughts on your changes, please review my comments.
Alright, so I created a folder where custom scripts can be made. Currently they are used in two situations:
Some things that need to be done now are the following:
|
On a side note if anyone from Zwin College ever comes across this - please confirm that the break times for the lower classes are handled properly as well, they should be, but not sure. |
… and add exceptions based on either location or title. You also have the option to disable the feature.
Alright, to fix your last change request I updated the way the address works. You can now select a default address and add exceptions to it either based on title or location. You also have the possibility to completely disable it. |
I added some documentation to |
…present (opendag par example). This feature will allow you to remove appointments if certain criteria are met. In the config you can tell when we should act (I don't think you'll want to cancel the appointment if you forgot your books though), change the values by simply adding or removing a '_' (underscore disbles it). Do note that if you are not permitted to skip the class (a.k.a. you just didn't show up) the appointment won't be removed.
…we had to update to a newer version of magister.js for this a lot of code had to be changed. Please run the code manually at least once and check a couple times if everything is being parsed correctly.
A while back I started getting authentication errors. Turn out Magister changed the way you are authenticated so When you start using these changes please make sure everything is still working as expected. A lot of variables have been renamed in |
Please wait with merging until #43 has been resolved. |
#43 Has been fixed as far as I know. This pull request is ready to be merged (again). |
…fix the error where the username is always seen as incorrect.
Any update? |
My school's Magister uses abbreviations such as "netl" for "Nederlands(e taal)" which were annoying me to be honest... so I extended your script to check if we have a replacement title for it, par example it looks up "netl" in the
titles.json
file and fetches the proper title which is "Nederlands", if it can't be found it just uses "netl".The result:

The
titles.json
file can easily be extended to include different abbreviations/names. The structure of the file should be pretty self-explanatory.