Fix #677, possible approach for transitive deps during hoist

[jppurcell9]

Here's a possible approach to fixing #677. Instead of installing the leaf dependencies directly, we install them in a "shadow" directory package-name/node_modules/_node_modules. Once all the leaves for package-name are installed, we go back and move each dep from package-name/node_modules/_node_modules/dep to package-name/node_modules/dep and symlink the shadow modules back into dep (package-name/node_modules/dep/node_modules -> package-name/node_modules/_node_modules). This approach should work for both npm and yarn clients.

This isn't ready to be merged - tests are failing and more complex cases need to be addressed (version collisions in the flattened shadow dir, for example). Just wanted to get some feedback on the approach to see if this is worth pursuing.

[evocateur]

I appreciate the proof-of-concept!

However, it looks suuuuper-complicated, and I'd rather not engage in too much hackery (aside from our current yarn bait-n-switch) with npm clients while work is underway to specify "native" behaviour that should solve this (yarn is coordinating with npm folks, too).

In the mean time, I'd be much happier with a solution that simply used npm install --global-style (regardless of npmClient option) to deal with non-hoisted package dependencies. It hits the sweet spot of "already tested elsewhere" and "acceptable compromise of functionality", for me.

[jppurcell9]

Agreed - and getting this right (not just this proof of concept) is going to be even more complicated. I'll close this and try again with --global-style.

[lock]

This thread has been automatically locked because there has not been any recent activity after it was closed. Please open a new issue for related bugs.