Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Reimplement Oco cloning #1749

Merged
merged 4 commits into from
Sep 22, 2023
Merged

Reimplement Oco cloning #1749

merged 4 commits into from
Sep 22, 2023

Conversation

DanikVitek
Copy link
Contributor

  • Make Clone impl generic.
  • Add clone_inplace method that accept &mut self to clone and replace the original value inplace with Oco::Counted in case if was Oco::Owned

@gbj
Copy link
Collaborator

gbj commented Sep 22, 2023

Looks good, thanks for all your work on this!

@gbj gbj merged commit baa5ea8 into leptos-rs:main Sep 22, 2023
55 checks passed
@DanikVitek DanikVitek deleted the oco_clone_inplace branch September 23, 2023 14:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@DanikVitek @gbj