Callbacks: Manual Clone and Debug impl; Visibility fix #1703
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Great to see, that this is now part of Leptos :). This PR mainly adds manual Clone and Debug implementations.
The manual
Clone
impl removes theClone
type bounds on the genericIn
andOut
types. All callback types can be cloned by simply cloning the innerRc
. The generic types are not important here.The Debug impls are debatable, as they are not strictly needed. But I would say it's good practice to supply users with a Debug impl for ALL custom types a library provides, as this is somewhat expected. (The ability to derive Debug on your types without problems.) If not provided, users would always need to add custom
Debug
impls for all structs in which they want to store someCallback
type and have a Debug impl on that struct.Also adds a missing
pub
modifier to constructViewCallback::new
.