Remove Clone requirement for slots in Vec #1564
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR removes the requirement for
S: Clone
for when rendering a list of slotsS
.It is currently required because the
view!
macro is building an array ofS
, then callingto_vec()
(which obviously requiresS: Clone
). This can be a problem when the slot containsChildrenFn
(i.e.Box<dyn Fn(Scope) -> Fragment
), as this type does not implementClone
.This PR removes this requirement by using the
vec!
macro directly instead.Take this code for example:
With the current version of leptos, it fails to compile with the following message:
With this PR, it build properly.