-
-
Notifications
You must be signed in to change notification settings - Fork 681
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Change leptos_axum generate_route_list function to not be async #1485
Conversation
Could you remind me of the reason you want it to be sync? My thinking is this:
So what's the use case that you need it not to be async for? Then we can weigh the pros and cons. |
Random joke. Ignore me
The fact that it's async means that it already uses a |
So, this PR (#1649) is a great example of why I want to keep it async, at least for now; it builds in some static-site-generation features, which rely on async, and uses |
Okay I've had a change of heart once I've looked at it in more depth, and in the context of #1649 as well (which no longer requires async route generation in this case). I think this is a good idea for consistency with the |
If axum is going to change, would it not be prudent to also make viz's function non-async? |
Closes #1392