feat: make Transition set_pending use #[prop(into)] (#1746)

leptos-rs · Sep 19, 2023 · 1bd47f3 · 1bd47f3
1 parent 661a038
commit 1bd47f3
Show file tree

Hide file tree

Showing 4 changed files with 6 additions and 6 deletions.
diff --git a/examples/hackernews/src/routes/stories.rs b/examples/hackernews/src/routes/stories.rs
@@ -80,7 +80,7 @@ pub fn Stories() -> impl IntoView {
                 <div>
                     <Transition
                         fallback=move || view! {  <p>"Loading..."</p> }
-                        set_pending=set_pending.into()
+                        set_pending
                     >
                         {move || match stories.get() {
                             None => None,

diff --git a/examples/hackernews_axum/src/routes/stories.rs b/examples/hackernews_axum/src/routes/stories.rs
@@ -70,7 +70,7 @@ pub fn Stories() -> impl IntoView {
                 >
                     <a href=move || format!("/{}?page={}", story_type(), page() + 1)
                         aria-label="Next Page"
-                    >
+                    >=
                         "more >"
                     </a>
                 </span>
@@ -79,7 +79,7 @@ pub fn Stories() -> impl IntoView {
                 <div>
                     <Transition
                         fallback=move || view! { <p>"Loading..."</p> }
-                        set_pending=set_pending.into()
+                        set_pending
                     >
                         {move || match stories.get() {
                             None => None,

diff --git a/examples/hackernews_islands_axum/src/routes/stories.rs b/examples/hackernews_islands_axum/src/routes/stories.rs
@@ -91,7 +91,7 @@ pub fn Stories() -> impl IntoView {
                 <div>
                     <Transition
                         fallback=|| ()
-                        set_pending=set_pending.into()
+                        set_pending
                     >
                         {move || stories.get().map(|story| story.map(|stories| view! {
                                 <ul>

diff --git a/leptos/src/transition.rs b/leptos/src/transition.rs
@@ -39,7 +39,7 @@ use std::{
 ///   <div>
 ///     <Transition
 ///       fallback=move || view! {  <p>"Loading..."</p>}
-///       set_pending=set_pending.into()
+///       set_pending
 ///     >
 ///       {move || {
 ///           cats.read().map(|data| match data {
@@ -72,7 +72,7 @@ pub fn Transition<F, E>(
     /// A function that will be called when the component transitions into or out of
     /// the `pending` state, with its argument indicating whether it is pending (`true`)
     /// or not pending (`false`).
-    #[prop(optional)]
+    #[prop(optional, into)]
     set_pending: Option<SignalSetter<bool>>,
     /// Will be displayed once all resources have resolved.
     children: Box<dyn Fn() -> Fragment>,