-
Notifications
You must be signed in to change notification settings - Fork 114
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: do not panic on interrupt channel for watch #408
base: main
Are you sure you want to change the base?
Conversation
I tested similar approach but I tolerated lag to max 20 000 000 and unfortunately this just caused endless loop of rebuilds. |
@Eraden You can check the behavior of this PR on top of the master branch. The logic has been changed in a separate merged PR in a way that if a notify comes in, the current builds will be terminated immediately and it starts to rebuild again. Please also consider that the lagged events will be run only once by this PR. (Assume we have 100 lagged events, the loop will be run only once to notify the 100 lagged events.) |
Unfortunately your fix is not working correctly. I justed tested it on my small project and I had endless loop
|
Can you provide a small reproducible example and its steps? nothing happens for me even on big projects! You may get distracted by logs on each file changes, especially if you use |
Closes: #385