Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't focus on inline buttons or icons in text input controls when pressing Tab #975

Merged
merged 4 commits into from
Mar 13, 2024
Merged

Conversation

tmijail
Copy link
Contributor

@tmijail tmijail commented Feb 26, 2024

Avoid tab-focusing on ControlIconLeft, ControlIconRight, ClearButton, InlineIncrementButton, InlineDecrementButton, and/or RevealButton present in TextBox, AutoSuggestBox, NumberBox and PasswordBox by setting IsTabStop=False

Pull request type

Please check the type of change your PR introduces:

  • Update
  • Bugfix
  • Feature
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • Documentation content changes

What is the current behavior?

When you press Tab on a text input control which has inline buttons (ClearButton, InlineIncrementButton, InlineDecrementButton, RevealButton), it focuses on those buttons instead of on the next control.

This breaks the flow and is inconsistent with WinUI3.

before.mp4

Issue Number: N/A

What is the new behavior?

Don't focus on buttons in text input controls with Tab.

after.mp4

Other information

Set `IsTabStop=False` in the `ClearButton`, `InlineIncrementButton`, `InlineDecrementButton`, and/or `RevealButton` present in `TextBox`, `AutoSuggestBox`, `NumberBox` and `PasswordBox`.
@tmijail tmijail requested a review from pomianowski as a code owner February 26, 2024 19:38
Copy link
Contributor Author

@tmijail tmijail left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same issue, but with ControlIconLeft and ControlIconRight. I checked AutoSuggestBox, PasswordBox, and TextBox and it seems like those don't have this issue.

@tmijail tmijail changed the title Don't focus on buttons in text input controls when pressing Tab Don't focus on inline buttons or icons in text input controls when pressing Tab Feb 27, 2024
@pomianowski pomianowski self-assigned this Mar 13, 2024
@pomianowski pomianowski added bug Something isn't working controls Changes to the appearance or logic of custom controls. styles Topic is related to styles labels Mar 13, 2024
@pomianowski pomianowski merged commit 5e115e8 into lepoco:development Mar 13, 2024
1 of 2 checks passed
@tmijail tmijail deleted the development branch March 13, 2024 12:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working controls Changes to the appearance or logic of custom controls. styles Topic is related to styles
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants