Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix FluentWindow behaviour #772

Merged

Conversation

Nice3point
Copy link
Contributor

@Nice3point Nice3point commented Sep 26, 2023

Pull request type

Please check the type of change your PR introduces:

  • Update
  • Bugfix
  • Feature
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • Documentation content changes

What is the current behavior?

The window dimensions do not change in runtime. Direct set width or height does not work

What is the new behavior?

Removing the default values from the .cs file solves the problem. The values themselves are already set in the style, so the window behaviour is not changed in any way

<Setter Property="Height" Value="600" />
<Setter Property="MinHeight" Value="320" />
<Setter Property="Width" Value="1100" />
<Setter Property="MinWidth" Value="460" />

@cla-bot
Copy link

cla-bot bot commented Sep 26, 2023

Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have the users @Nice3point on file. In order for us to review and merge your code, please contact the project maintainers to get yourself added.

@pomianowski pomianowski merged commit 66929e2 into lepoco:development Oct 9, 2023
@Nice3point Nice3point deleted the development_fix_fluentwindow branch November 17, 2023 09:11
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Nov 17, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants