Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Optimizes the WindowBackdrop Settings before version 22H1 #750

Merged
merged 1 commit into from
Sep 5, 2023

Conversation

MakesYT
Copy link
Contributor

@MakesYT MakesYT commented Sep 5, 2023

Optimizes the WindowBackdrop Settings before version 22H1,Thus automatically switches to a supported effect instead of an error in earlier versions
Sets the IconSourceElementConverter to public, sometimes need to use this converter

Pull request type

Please check the type of change your PR introduces:

  • Update
  • Bugfix
  • Feature
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • Documentation content changes

What is the current behavior?

If the WindowBackdrop type Acrylic is not supported in an early version, it will fail and throw error.
Can,t use IconSourceElementConverter

Issue Number: N/A

What is the new behavior?

  • automatically switches to a supported effect instead of an error in earlier versions

Other information

Make IconSourceElementConverter to public
@MakesYT MakesYT requested a review from pomianowski as a code owner September 5, 2023 05:20
@cla-bot
Copy link

cla-bot bot commented Sep 5, 2023

Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have the users @MakesYT on file. In order for us to review and merge your code, please contact the project maintainers to get yourself added.

@pomianowski pomianowski self-assigned this Sep 5, 2023
@pomianowski pomianowski merged commit 7e0667c into lepoco:development Sep 5, 2023
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 8, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants