Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Perf: Exclude the unnecessary fields defined on a specific version #1202

Merged
merged 2 commits into from
Oct 24, 2024

Conversation

textGamex
Copy link
Contributor

@textGamex textGamex commented Aug 15, 2024

Exclude the definition of the CanCenterOverWPFOwnerPropertyInfo field in .NET 8.0 or higher

Pull request type

Please check the type of change your PR introduces:

  • Update
  • Bugfix
  • Feature
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • Documentation content changes

What is the current behavior?

In the current implementation, even if the CanCenterOverWPFOwnerPropertyInfo field is not used (.NET 8 and higher), this field is still being initialized.

Issue Number: N/A

What is the new behavior?

Exclude the definition of the CanCenterOverWPFOwnerPropertyInfo field in .NET 8.0 or higher

@textGamex textGamex requested a review from pomianowski as a code owner August 15, 2024 23:49
@github-actions github-actions bot added controls Changes to the appearance or logic of custom controls. PR Pull request dotnet release labels Aug 15, 2024
@pomianowski pomianowski merged commit 950ade6 into lepoco:main Oct 24, 2024
2 checks passed
@textGamex textGamex deleted the Fix branch October 24, 2024 09:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
controls Changes to the appearance or logic of custom controls. dotnet PR Pull request release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants