Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/numericupdown control #1022

Open
wants to merge 12 commits into
base: main
Choose a base branch
from

Conversation

koal44
Copy link
Contributor

@koal44 koal44 commented Mar 27, 2024

Pull request type

  • Feature

What is the new behavior?

Added new control NumericUpDown. The library already has a NumberBox control, but this is my version.

numeric-up-down

  • Implemented new control NumericUpDown
  • Showcased it in the Gallery App

Other information

@koal44 koal44 requested a review from pomianowski as a code owner March 27, 2024 04:02
@github-actions github-actions bot added controls Changes to the appearance or logic of custom controls. styles Topic is related to styles PR Pull request gallery WPF UI Gallery dotnet labels Mar 27, 2024
koal44 and others added 2 commits March 27, 2024 13:44
…purely cosmetic

Fixed a bug with using `Coerce(ValueProperty)` where ValueProperty would, under some conditions, revert to its initial xaml value rather than the current Value
@pomianowski
Copy link
Member

Hey @koal44, thanks for putting the work into the control, but we should avoid creating two controls to do the same thing. If you have any ideas on how to improve NumberBox, I think this would be a better approach.

@LucaSamarCMA
Copy link

it would be great to have this control

@pomianowski pomianowski deleted the branch lepoco:main July 26, 2024 12:02
@pomianowski pomianowski reopened this Jul 26, 2024
@pomianowski pomianowski changed the base branch from development to main July 26, 2024 12:08
@github-actions github-actions bot added the ⭐ top pull request Top pull request. label Dec 7, 2024
@github-actions github-actions bot mentioned this pull request Dec 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
controls Changes to the appearance or logic of custom controls. dotnet gallery WPF UI Gallery PR Pull request release ⭐ top pull request Top pull request. styles Topic is related to styles
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants