cleanup(storybook): add some stricter types for the storybook executor (

nrwl#5805) Co-authored-by: Dominik Pieper <[email protected]>
leosvelperez · May 27, 2021 · aaad6f0 · aaad6f0
1 parent 2d2880e
commit aaad6f0
Show file tree

Hide file tree

Showing 5 changed files with 8 additions and 1 deletion.
diff --git a/docs/angular/api-storybook/executors/storybook.md b/docs/angular/api-storybook/executors/storybook.md
@@ -76,6 +76,8 @@ Default: `@storybook/angular`
 
 Type: `string`
 
+Possible values: `@storybook/angular`, `@storybook/react`, `@storybook/html`
+
 Storybook framework npm package
 
 ### watch

diff --git a/docs/node/api-storybook/executors/storybook.md b/docs/node/api-storybook/executors/storybook.md
@@ -77,6 +77,8 @@ Default: `@storybook/angular`
 
 Type: `string`
 
+Possible values: `@storybook/angular`, `@storybook/react`, `@storybook/html`
+
 Storybook framework npm package
 
 ### watch

diff --git a/docs/react/api-storybook/executors/storybook.md b/docs/react/api-storybook/executors/storybook.md
@@ -77,6 +77,8 @@ Default: `@storybook/angular`
 
 Type: `string`
 
+Possible values: `@storybook/angular`, `@storybook/react`, `@storybook/html`
+
 Storybook framework npm package
 
 ### watch

diff --git a/packages/storybook/src/executors/storybook/schema.json b/packages/storybook/src/executors/storybook/schema.json
@@ -7,6 +7,7 @@
     "uiFramework": {
       "type": "string",
       "description": "Storybook framework npm package",
+      "enum": ["@storybook/angular", "@storybook/react", "@storybook/html"],
       "default": "@storybook/angular",
       "hidden": true
     },

diff --git a/packages/storybook/src/executors/storybook/storybook.impl.ts b/packages/storybook/src/executors/storybook/storybook.impl.ts
@@ -15,7 +15,7 @@ export interface StorybookConfig {
 }
 
 export interface StorybookExecutorOptions {
-  uiFramework: string;
+  uiFramework: '@storybook/angular' | '@storybook/react' | '@storybook/html';
   projectBuildConfig?: string;
   config: StorybookConfig;
   host?: string;