verify dest dir is also parsed for env values

leopardslab · Jun 15, 2019 · 8a3bb77 · 8a3bb77
1 parent dae7504
commit 8a3bb77
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 3 deletions.
diff --git a/pkg/config/config.go b/pkg/config/config.go
@@ -283,7 +283,6 @@ func parseEnv(configs *Configs) error {
 // DecodeMount parses mount format for directories to be mounted as bind volumes
 func DecodeMount(mounts []string, step *docker.Step) error {
 	for _, m := range mounts {
-
 		arr := strings.Split(
 			strings.Trim(strings.Trim(m, `'`), `"`),
 			":",

diff --git a/pkg/config/config_test.go b/pkg/config/config_test.go
@@ -335,7 +335,7 @@ func TestDecodeMount(t *testing.T) {
 
 func TestDecodeMountWithEnvironmentVariable(t *testing.T) {
 	step := &docker.Step{}
-	mounts := []string{"`$HOME`:/app"}
+	mounts := []string{"`$HOME`:`$HOME`"}
 
 	err := DecodeMount(mounts, step)
 
@@ -349,6 +349,9 @@ func TestDecodeMountWithEnvironmentVariable(t *testing.T) {
 		t.Fatalf("expected ExtMounts to be of length 1, got %d", len((*step).ExtMounts))
 	}
 	if (*step).ExtMounts[0].Source != util.HomeDir {
-		t.Fatalf("expected ExtMounts to be %s, got %s", util.HomeDir, (*step).ExtMounts[0].Source)
+		t.Fatalf("expected ExtMounts Source to be %s, got %s", util.HomeDir, (*step).ExtMounts[0].Source)
+	}
+	if (*step).ExtMounts[0].Target != util.HomeDir {
+		t.Fatalf("expected ExtMounts Source to be %s, got %s", util.HomeDir, (*step).ExtMounts[0].Target)
 	}
 }