Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

dump.c: When dumping SVt_PVOBJ, show field names as well #19

Merged
merged 1 commit into from
Sep 9, 2022
Merged

dump.c: When dumping SVt_PVOBJ, show field names as well #19

merged 1 commit into from
Sep 9, 2022

Conversation

wolfsage
Copy link

This way, instead of:

Field No. 0
SV = PV(0x5638ccf57fb0) at 0x5638ccf7b9c0
  REFCNT = 1
  ...

You get:

Field No. 0 ($name)
SV = PV(0x5638ccf57fb0) at 0x5638ccf7b9c0
  REFCNT = 1

@leonerd leonerd force-pushed the feature-class branch 2 times, most recently from 6f74f5c to badeffa Compare September 1, 2022 11:06
@wolfsage wolfsage force-pushed the feature-class-dump-field-names branch from 4dff8ee to 527d595 Compare September 9, 2022 13:10
leonerd
leonerd approved these changes Sep 9, 2022
View reviewed changes
Copy link
Owner

@leonerd leonerd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@wolfsage
dump.c: When dumping SVt_PVOBJ, show field names as well
78a613f 
This way, instead of:

    Field No. 0
    SV = PV(0x5638ccf57fb0) at 0x5638ccf7b9c0
      REFCNT = 1
      ...

You get:

    Field No. 0 ($name)
    SV = PV(0x5638ccf57fb0) at 0x5638ccf7b9c0
      REFCNT = 1
@wolfsage wolfsage force-pushed the feature-class-dump-field-names branch from 527d595 to 78a613f Compare September 9, 2022 13:40
@wolfsage wolfsage mentioned this pull request Sep 9, 2022
Open
@leonerd leonerd merged commit 53d3bc2 into leonerd:feature-class Sep 9, 2022
@wolfsage
Copy link
Author

wolfsage commented Sep 9, 2022

Thanks!

@wolfsage wolfsage deleted the feature-class-dump-field-names branch September 9, 2022 17:51
leonerd pushed a commit that referenced this pull request Jul 19, 2024
@rra @jkeenan
cpan/podlators - Update to version v6.0.2 (with v6.0.1 and v6.0.0)
3c9d78c 
v6.0.0 - 2024-07-10

 - Drop support for Perl 5.10.  podlators now requires Perl 5.12 or later.

 - podlators now uses semantic versioning for the package and module
   versions, with a v prefix to work with Perl's packaging system.

 - Pod::Man now translates all "-" characters in the input into *roff "\-"
   escapes (normally rendered as an ASCII hyphen-minus, U+002D) rather
   than using fragile heuristics to decide which characters represent true
   hyphens and which represent ASCII hyphen-minus.  The previous
   heuristics misrendered command names such as apt-get, causing search
   and cut-and-paste issues.  This change may cause line-break issues with
   long hyphenated phrases.  In cases where the intent is a true hyphen,
   consider using UTF-8 as the POD character set (declared with =encoding)
   and using true Unicode hyphens instead of the ASCII "-" character.

 - Pod::Man now disables the special *roff interpretation of "`" and "'"
   characters as paired quotes everywhere, not just in verbatim text, thus
   forcing them to be interpreted as the regular ASCII characters.  This
   also disables the use of "``" and "''" for paired double-quotes.  The
   rationale is similar to that for hyphens: there is no way to tell from
   the POD source that the special interpretation as quotes is intended.
   To produce paired typographic quotes in the output, use UTF-8 and
   Unicode paired quote characters.

 - Man page references in L<> that are detected as such by Pod::Simple are
   now always formatted as man page references even if our normal
   heuristic would not detect them.  This fixes the formatting of
   constructions such as @@RXVT_NAME@@Perl(3), which are used by packages
   that format a man page with POD and then substitute variables into it
   at build time.  Thanks to Marco Sirabella for the analysis and an
   initial patch.  (GitHub #21)

 - Add a workaround to Pod::Man to force persistent ragged-right
   justification under nroff with groff 1.23.0.  Thanks to Guillem Jover
   for the report and G. Branden Robinson for the analysis.  (GitHub Perl#23)

 - Fix wrapping of text with S<> markup in all subclasses of Pod::Text.
   Thanks to Jim Avera for the report.  (GitHub #24)

 - Pod::Man now forces a blank line after a nested list contains only
   =item tags without bodies.  In previous versions, the blank line before
   the next item in the surrounding =over block was not included.  Thanks
   to Julien ÉLIE for the report.  (GitHub #26)

 - Import PerlIO before checking for layers so that PerlIO::F_UTF8 is
   available, which fixes double-encoding of output when a :utf8 layer is
   in place and PerlIO is not imported.  Thanks to youpong for the bug
   report, James Keenan for the elaboration, and Graham Knop for the fix.
   (GitHub #25)

 - pod2text --help now exits with status 0, not 1, matching normal UNIX
   command behavior and the behavior of pod2man.  (GitHub #19)

 - Fix tests when NO_COLOR is set in the environment.  (GitHub #20)

v6.0.1 - 2024-07-12

 - Remove autodie from the module build process.  When built as part of
   Perl core, podlators is built before autodie is available.  Thanks to
   James E Keenan for the report and a draft patch.  (GitHub Perl#33)

v6.0.2 - 2024-07-14

 - Fix removal of scripts/pod2man and scripts/pod2text by make realclean,
   broken in the v6.0.0 release.  Thanks to James E Keenan for the report.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@leonerd leonerd leonerd approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@wolfsage @leonerd