Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fp #34

Merged
merged 11 commits into from
May 21, 2019
Merged

Fp #34

merged 11 commits into from
May 21, 2019

Conversation

rdaly525
Copy link
Collaborator

@rdaly525 rdaly525 commented May 20, 2019

Sorry... I merged this way too early.

Here is the original FP PR

@rdaly525 rdaly525 requested review from leonardt and cdonovick May 20, 2019 20:52
@cdonovick cdonovick requested a review from rsetaluri May 20, 2019 20:52
@cdonovick
Copy link
Collaborator

cdonovick commented May 20, 2019

reposting from #30 which was merged prematurely

Not quite feature complete -- a few methods do not work for NaN / denormals -- however as lassen does not require these this should be good enough for now.

The changes to AbstractBitVectorMeta are an artifact of trying to use it for the metaclass of FPVector. This however, turned out to not be possible for a number of reasons. I did not revert these changes as they do not effect behavior and they make AbstractBitVectorMeta more extensible.

Introduces dependency on gmpy2 which has system dependencies gmp, mpfr, mpc. Could potentially create a separate package hwtypes[float] so that hwtypes remains pure python. If we go down that route we probably should separate hwtypes[smt] as well.

@cdonovick
Copy link
Collaborator

@rsetaluri @leonardt @makaimann can you guys update your system requirements? (see https://github.com/leonardt/hwtypes/blob/fp/.travis.yml)

@leonardt
Copy link
Owner

I've added those dependencies to the magma, mantle, pycoreir, and fault travis repos. Let me know if I forgot any (we'll find out soon enough).

pycoreir has a slightly trickier setup (not using traivs addons) so verifying that it works, also with osx. I believe the required brew command is brew install gmp mpfr libmpc. Can we add the apt/brew commands to the README under setup/install?

@cdonovick
Copy link
Collaborator

@leonardt I have updated the readme

@rdaly525
Copy link
Collaborator Author

lassen's PR: StanfordAHA/lassen#81

@rdaly525
Copy link
Collaborator Author

rdaly525 commented May 21, 2019

I think the dependencies are:
-magma
-mantle
-fault
-pycoreir
-Cosa
-peak
-metamapper
-lassen
-garnet

@rdaly525
Copy link
Collaborator Author

peak's PR cdonovick/peak#49

@makaimann
Copy link

CoSA’s PR: cristian-mattarei/CoSA#84

@rdaly525
Copy link
Collaborator Author

Everyone should be able to merge their PRs now. Afterwards, this PR can be merged

@cdonovick
Copy link
Collaborator

@rsetaluri @rdaly525 is Garnet updated? @Kuree Also does canal depend on hwtypes?

@Kuree
Copy link

Kuree commented May 21, 2019

It's ready to merge.

Here is the list of repos depends on hwtypes:

  • gemstone
  • canal
  • garnet

The entire gemstone ecosystem is handled by containers so these repos are always ready to merge once the docker container is updated.

@Kuree
Copy link

Kuree commented May 21, 2019

Can someone merge it in and release the package? It's breaking garnet right now.

@leonardt leonardt merged commit 3197920 into master May 21, 2019
@leonardt leonardt deleted the fp branch May 21, 2019 21:29
@cdonovick cdonovick mentioned this pull request May 22, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants