Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add broken tests #326

Open
wants to merge 6 commits into
base: master
Choose a base branch
from
Open

Add broken tests #326

wants to merge 6 commits into from

Conversation

cdonovick
Copy link
Collaborator

@cdonovick cdonovick commented Aug 1, 2023

Related issue #327

@cdonovick
Copy link
Collaborator Author

Due to some sort of caching issue I can't test BrokenProtocol and FixedProtocol at the same time. Not sure how to resolve.

@leonardt
Copy link
Owner

leonardt commented Aug 2, 2023

Is the cache issue at the magma/python level compile? Or the verilator test?

@cdonovick
Copy link
Collaborator Author

Is the cache issue at the magma/python level compile? Or the verilator test?

Sorry I should have provided more detail. If I add FixedProtocol to the list of BoxT I get an attribute error about BrokenProtocol having no debug_name in the FixedProtocol cases (this is the error I get in the BrokenProtocol cases). If I run only FixedProtocol it has no errors. If I set BoxT = [FixedProtocol, BrokenProtocol] I get no errors. So some sort of Python level caching issue.

@leonardt
Copy link
Owner

I think a broader fix for this issue is to have fault unpack protocol values at the entrypoint to any fault code (i.e. the fault internals just operate on the underlying magma values). I added the required unpacking for these tests, but I suspect there are (many) other places we may need to the get_magma_value logic. However, this is likely much simpler to do at the API boundary rather than finding all the places internally where we need to call get_magma_value

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants