🐛 fixes sandbox error case in chrome #13
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…fter clearing the input, also add some documentation about it
axelmarciano
changed the title
This comment has been minimized.
This comment has been minimized.
Repository owner
deleted a comment from
axelmarciano
Jan 15, 2022
Repository owner
deleted a comment from
axelmarciano
Jan 15, 2022
leonardodino
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the example the input value is cleared via
input.value = ''.Yet the handler function that manage the selection logic is called on 'input' and 'selectionchange' so without an event dispatch it feels like the input is blurred on chrome.
I have also added some comments on the example.
fixes #10