Skip to content

Commit

Permalink
perf: nullsFirst = true by default
Browse files Browse the repository at this point in the history
BREAKING CHANGE: nullsFirst = true by default

We previously set `nullsFirst = false` by default, but it caused some
perf issues: supabase#239
  • Loading branch information
soedirgo committed Aug 5, 2022
1 parent dfb808a commit 251e13f
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion src/PostgrestTransformBuilder.ts
Original file line number Diff line number Diff line change
Expand Up @@ -46,7 +46,7 @@ export default class PostgrestTransformBuilder<T> extends PostgrestBuilder<T> {
column: keyof T,
{
ascending = true,
nullsFirst = false,
nullsFirst = true,
foreignTable,
}: { ascending?: boolean; nullsFirst?: boolean; foreignTable?: string } = {}
): this {
Expand Down

0 comments on commit 251e13f

Please sign in to comment.