storage: Fix for leo-project/leofs#553 #948
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mocchira
requested changes
Dec 6, 2017
| @@ -1180,9 +1180,11 @@ get_active_redundancies(_, []) -> | |||
| get_active_redundancies(Quorum, Redundancies) -> | |||
| AvailableNodes = [RedundantNode || | |||
| #redundant_node{available = true} = RedundantNode <- Redundancies], | |||
| UnavailableNodes = [RedundantNode || | |||
| #redundant_node{available = false} = RedundantNode <- Redundancies], | |||
There was a problem hiding this comment.
Why not just having the flag that indicates if there is unavailable node instead of list UnavailableNodes?
| case (Quorum =< erlang:length(AvailableNodes)) of | ||
| true -> | ||
| {ok, AvailableNodes}; | ||
| {ok, AvailableNodes, UnavailableNodes}; |
There was a problem hiding this comment.
As described above, just return bool (true/false) instead of list.
| {error, Error}; | ||
| read_and_repair_1(ReadParams, [Node|Rest], AvailableNodes, Errors) -> | ||
| %%read_and_repair_1(_,[],_,[Error|_]) -> | ||
| %% {error, Error}; |
| %%read_and_repair_1(_,[],_,[Error|_]) -> | ||
| %% {error, Error}; | ||
|
|
||
| read_and_repair_1(_,[],_,[], Errors) -> |
There was a problem hiding this comment.
Match against false instead of the empty list.
| @@ -1200,19 +1202,34 @@ get_active_redundancies(Quorum, Redundancies) -> | |||
| Cause::any()). | |||
| read_and_repair(#read_parameter{quorum = Q} = ReadParams, Redundancies) -> | |||
| case get_active_redundancies(Q, Redundancies) of | |||
| {ok, AvailableNodes} -> | |||
| read_and_repair_1(ReadParams, AvailableNodes, AvailableNodes, []); | |||
| {ok, AvailableNodes, UnavailableNodes} -> | |||
There was a problem hiding this comment.
the name also should be renamed if it become the flag like HasUnavailableNodes.
windkit
force-pushed
the
issue_553
branch
2 times, most recently
from
a24b423 to
930b1d4
Compare
mocchira
approved these changes
Dec 7, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.