Resolve leo-project/leofs/issues/941 #1008
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
yosukehara
commented
Mar 23, 2018
•
yosukehara
commented
- Link: Making more information available over SNMP for storage nodes #941
- Link: [doc] Fix recover-cluster's section because there is a possibility of misunderstanding #1002
|
I've also fixed recover-related documentation, which is included in this PR. |
mocchira
requested changes
Mar 27, 2018
| | Port | 4010..4014 | | ||
| | Branch | 1.3.6.1.4.1.35450 | | ||
| | [snmpa\_storage\_0](https://github.com/leo-project/leofs/tree/master/apps/leo_storage/snmp/snmpa_storage_0) | Port: 4020 | |
There was a problem hiding this comment.
wrong: Port: 4020
correct: Port: 4010
| | Branch | 1.3.6.1.4.1.35450 | | ||
| | [snmpa\_storage\_0](https://github.com/leo-project/leofs/tree/master/apps/leo_storage/snmp/snmpa_storage_0) | Port: 4020 | | ||
| | [snmpa\_storage\_1](https://github.com/leo-project/leofs/tree/master/apps/leo_storage/snmp/snmpa_storage_1) | Port: 4021 | |
There was a problem hiding this comment.
wrong: Port: 4021
correct: Port: 4011
| | [snmpa\_storage\_0](https://github.com/leo-project/leofs/tree/master/apps/leo_storage/snmp/snmpa_storage_0) | Port: 4020 | | ||
| | [snmpa\_storage\_1](https://github.com/leo-project/leofs/tree/master/apps/leo_storage/snmp/snmpa_storage_1) | Port: 4021 | | ||
| | [snmpa\_storage\_2](https://github.com/leo-project/leofs/tree/master/apps/leo_storage/snmp/snmpa_storage_2) | Port: 14020 | |
There was a problem hiding this comment.
wrong: Port: 14020
correct: Port: 4012
| | [snmpa\_storage\_1](https://github.com/leo-project/leofs/tree/master/apps/leo_storage/snmp/snmpa_storage_1) | Port: 4021 | | ||
| | [snmpa\_storage\_2](https://github.com/leo-project/leofs/tree/master/apps/leo_storage/snmp/snmpa_storage_2) | Port: 14020 | | ||
| | [snmpa\_storage\_3](https://github.com/leo-project/leofs/tree/master/apps/leo_storage/snmp/snmpa_storage_3) | Port: 14021 | |
There was a problem hiding this comment.
wrong: Port: 14021
correct: Port: 4013
| end, | ||
| SoFar + N | ||
| end, 0, ?del_dir_queue_list()), | ||
| catch snmp_generic:variable_set(Id, V), |
There was a problem hiding this comment.
Strictly, check_number should be applied to V
| _ -> | ||
| 0 | ||
| end, | ||
| catch snmp_generic:variable_set(Id, V), |
|
@mocchira PTAL |
mocchira
requested changes
Mar 27, 2018
| N; | ||
| _ -> | ||
| 0 | ||
| end; |
There was a problem hiding this comment.
What I meant in the previous comment is that the value should be rounded to leo_math:power(2,32) as check_number does because it can be higher than 4294967296.
| N; | ||
| _ -> | ||
| 0 | ||
| end; |
mocchira
approved these changes
Mar 27, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.