gateway: Fix #845

apps/leo_gateway/src/leo_gateway_s3_api.erl

@@ -1192,16 +1192,19 @@ handle_multi_upload_1(true, Req, Path, UploadId,
 
     case leo_gateway_rpc_handler:get(Path4Conf) of
         {ok, #?METADATA{meta = CMetaBin}, _} ->
-            _ = leo_gateway_rpc_handler:delete(Path4Conf),
-
             BodyOpts = case TransferDecodeFun of
                            undefined ->
                                [];
                            _ ->
                                [{transfer_decode, TransferDecodeFun, TransferDecodeState}]
                        end,
             Ret = cowboy_req:body(Req, BodyOpts),
-            handle_multi_upload_2(Ret, Req, Path, ChunkedLen, BucketInfo, CMetaBin);
+            {ok, Req2} = handle_multi_upload_2(Ret, Req, Path, ChunkedLen, BucketInfo, CMetaBin),
+            %% Deleting a temporary object after getting the upload done could decrease the odds
+            %% inconsistencies against the temporary object could happen.
+            %% This hack should mitigate https://github.com/leo-project/leofs/issues/845
+            _ = leo_gateway_rpc_handler:delete(Path4Conf),
+            {ok, Req2};
         _ ->
             ?reply_service_unavailable_error([?SERVER_HEADER], Path, <<>>, Req)
     end;