-
Notifications
You must be signed in to change notification settings - Fork 9
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Improve object-storage-container's launch for leo-project/leofs/issue…
- Loading branch information
1 parent
9806de8
commit 8756530
Showing
1 changed file
with
7 additions
and
7 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
8756530
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
file:read_file_info is more efficient than filelib:file_size to retrieve the size of file when you already have a file handle.
8756530
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@yosukehara ping
8756530
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@yosukehara
Sorry that I had a miss understanding about the file:read_file_info spec.
(I assumed the first argument take a IoDevice type)
So LGTM with this commit.