Fix OS X build on GitHub actions #90
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The OS X version in the pipeline is deprecated: https://github.blog/changelog/2022-07-20-github-actions-the-macos-10-15-actions-runner-image-is-being-deprecated-and-will-be-removed-by-8-30-22/ The test script failed on a sed version difference between OS X and GNU sed, so I removed those for now.
lenticularis39
approved these changes
May 9, 2023
|
Ah, I only have a macOS 11 VM. Nevermind, someone will test it eventually, I got back to AXPbox because @gdwnldsKSC made his own es40 fork, so we exchanged some observations on the VirtuallyFun Discord and I decided to fix some issues. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I noticed your recent commits regarding scsi and also saw that the os x build broke due to the runner os x version (10.15) not being available anymore (https://github.blog/changelog/2022-07-20-github-actions-the-macos-10-15-actions-runner-image-is-being-deprecated-and-will-be-removed-by-8-30-22/)
This branch updates the runner script to use OS X 12. I have no method to test the binary because i do not have a recent mac.
The tests did run, however due to version differences between GNU sed and OS X sed I disabled running the script.
Apple ARM (m1) runners are not yet available, once they are I can add them and we'll also have an M1 / M2 build available: actions/runner#805 (comment)