-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
implement fitting sequence #35
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
ahuang314
commented
Feb 2, 2025
•
edited
Loading
edited
- Implements FittingSequence along with all of the samplers that are used in lenstronomy, with the exception of "psf_iteration", which does not work in jaxtronomy since ImageModel.update_psf is not implemented, and "calibrate_images", since joint-linear is not supported in jaxtronomy. Support for the Jaxopt minimizer has been added to FittingSequence. The rest of the file is copy-pasted from lenstronomy.
- Small changes in LikelihoodModule: default value of check_bounds has been changed to True to stay consistent with lenstronomy (not sure why I changed it to False in the first place), and fixed compatibility issues with Cobaya by converting the jax float to a numpy float in the likelihood() function.
- Renamed the ImageData.exp_map variable to ImageData.exposure_map to stay consistent with lenstronomy (not sure how I got the name incorrect the first time)
for more information, see https://pre-commit.ci
for more information, see https://pre-commit.ci
for more information, see https://pre-commit.ci
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #35 +/- ##
========================================
Coverage 99.84% 99.85%
========================================
Files 48 49 +1
Lines 3809 4065 +256
========================================
+ Hits 3803 4059 +256
Misses 6 6
|
for more information, see https://pre-commit.ci
for more information, see https://pre-commit.ci
for more information, see https://pre-commit.ci
for more information, see https://pre-commit.ci
sibirrer
approved these changes
Feb 4, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you @ahuang314 !
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.