Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

implement fitting sequence #35

Merged
merged 29 commits into from
Feb 4, 2025
Merged

implement fitting sequence #35

merged 29 commits into from
Feb 4, 2025

Conversation

ahuang314
Copy link
Collaborator

@ahuang314 ahuang314 commented Feb 2, 2025

  1. Implements FittingSequence along with all of the samplers that are used in lenstronomy, with the exception of "psf_iteration", which does not work in jaxtronomy since ImageModel.update_psf is not implemented, and "calibrate_images", since joint-linear is not supported in jaxtronomy. Support for the Jaxopt minimizer has been added to FittingSequence. The rest of the file is copy-pasted from lenstronomy.
  2. Small changes in LikelihoodModule: default value of check_bounds has been changed to True to stay consistent with lenstronomy (not sure why I changed it to False in the first place), and fixed compatibility issues with Cobaya by converting the jax float to a numpy float in the likelihood() function.
  3. Renamed the ImageData.exp_map variable to ImageData.exposure_map to stay consistent with lenstronomy (not sure how I got the name incorrect the first time)

Copy link

codecov bot commented Feb 2, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 99.85%. Comparing base (477b114) to head (29a406e).
Report is 30 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff            @@
##             main      #35    +/-   ##
========================================
  Coverage   99.84%   99.85%            
========================================
  Files          48       49     +1     
  Lines        3809     4065   +256     
========================================
+ Hits         3803     4059   +256     
  Misses          6        6            
Files with missing lines Coverage Δ
jaxtronomy/Data/image_noise.py 100.00% <100.00%> (ø)
jaxtronomy/Data/imaging_data.py 100.00% <ø> (ø)
jaxtronomy/Sampling/likelihood.py 100.00% <100.00%> (ø)
jaxtronomy/Workflow/fitting_sequence.py 100.00% <100.00%> (ø)

@ahuang314 ahuang314 requested a review from sibirrer February 2, 2025 21:46
Copy link
Contributor

@sibirrer sibirrer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @ahuang314 !

@ahuang314 ahuang314 merged commit d2b99d1 into lenstronomy:main Feb 4, 2025
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants