Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove manylog and integrate a monitoring thread for worker logs #539

Merged
merged 19 commits into from
Dec 7, 2024

Conversation

mdekstrand
Copy link
Member

This removes manylog and directly implements Structlog-compatible worker log aggregation in a monitoring thread in LensKit.

@mdekstrand mdekstrand added batch Batch recommendation facilities internals Internal infrastructure (parallelism, math, etc.) labels Dec 5, 2024
@mdekstrand mdekstrand added this to the 2025.1 milestone Dec 5, 2024
Copy link

codecov bot commented Dec 5, 2024

Codecov Report

Attention: Patch coverage is 71.07692% with 94 lines in your changes missing coverage. Please review.

Project coverage is 90.41%. Comparing base (11ef984) to head (c29c171).
Report is 19 commits behind head on main.

Files with missing lines Patch % Lines
lenskit/lenskit/logging/monitor.py 74.12% 37 Missing ⚠️
lenskit/lenskit/logging/worker.py 79.79% 20 Missing ⚠️
lenskit/lenskit/logging/progress/_rich.py 21.05% 15 Missing ⚠️
lenskit/lenskit/logging/_console.py 52.63% 9 Missing ⚠️
lenskit/lenskit/logging/config.py 40.00% 9 Missing ⚠️
lenskit/lenskit/logging/processors.py 0.00% 3 Missing ⚠️
lenskit/lenskit/parallel/worker.py 87.50% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #539      +/-   ##
==========================================
- Coverage   91.17%   90.41%   -0.77%     
==========================================
  Files          96       98       +2     
  Lines        5442     5720     +278     
==========================================
+ Hits         4962     5172     +210     
- Misses        480      548      +68     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@mdekstrand mdekstrand merged commit c29c171 into lenskit:main Dec 7, 2024
33 of 35 checks passed
@mdekstrand mdekstrand deleted the feature/log-runs branch December 7, 2024 04:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
batch Batch recommendation facilities internals Internal infrastructure (parallelism, math, etc.)
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

1 participant