Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Softmax ranker and remove legacy code #529

Merged
merged 19 commits into from
Nov 27, 2024

Conversation

mdekstrand
Copy link
Member

@mdekstrand mdekstrand commented Nov 27, 2024

This does 2 things, unfortunately:

  • Implement a Softmax ranker to replace the Gumbel-based Plackett-Luce ranker in the old code
  • Remove legacy algorithms, batch inference, and evaluation support and its tests

There is still some legacy code to remove, but this gets rid of a lot of it.

@mdekstrand mdekstrand added build Build, test, and platform support pipeline LensKit pipeline abstraction labels Nov 27, 2024
@mdekstrand mdekstrand added this to the 2025.1 milestone Nov 27, 2024
@mdekstrand mdekstrand self-assigned this Nov 27, 2024
Copy link

codecov bot commented Nov 27, 2024

Codecov Report

Attention: Patch coverage is 87.50000% with 9 lines in your changes missing coverage. Please review.

Project coverage is 92.48%. Comparing base (c08f333) to head (56c132b).
Report is 20 commits behind head on main.

Files with missing lines Patch % Lines
lenskit/lenskit/util/test.py 82.75% 5 Missing ⚠️
lenskit/lenskit/basic/random.py 88.88% 3 Missing ⚠️
lenskit/lenskit/splitting/__init__.py 85.71% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #529      +/-   ##
==========================================
- Coverage   93.18%   92.48%   -0.71%     
==========================================
  Files         101       87      -14     
  Lines        7063     5312    -1751     
==========================================
- Hits         6582     4913    -1669     
+ Misses        481      399      -82     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@mdekstrand mdekstrand merged commit 56c132b into lenskit:main Nov 27, 2024
33 of 35 checks passed
@mdekstrand mdekstrand deleted the tweak/demolish branch November 27, 2024 21:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
build Build, test, and platform support pipeline LensKit pipeline abstraction
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

1 participant