Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Incorporate implicit bridge into monorepo #425

Merged
merged 9 commits into from
Jun 10, 2024

Conversation

mdekstrand
Copy link
Member

This advances the LensKit monorepo integration (#387) by integrating the implicit bridge.

@mdekstrand mdekstrand added the components LensKit recommendation components label Jun 10, 2024
@mdekstrand mdekstrand added this to the 2024.1 milestone Jun 10, 2024
@mdekstrand mdekstrand self-assigned this Jun 10, 2024
Copy link

codecov bot commented Jun 10, 2024

Codecov Report

Attention: Patch coverage is 90.09901% with 10 lines in your changes missing coverage. Please review.

Project coverage is 90.93%. Comparing base (ebf66d6) to head (f92d4fe).
Report is 586 commits behind head on main.

Files with missing lines Patch % Lines
lenskit-implicit/lenskit/implicit.py 89.13% 10 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #425      +/-   ##
==========================================
- Coverage   90.96%   90.93%   -0.04%     
==========================================
  Files          45       46       +1     
  Lines        3078     3176      +98     
==========================================
+ Hits         2800     2888      +88     
- Misses        278      288      +10     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@mdekstrand mdekstrand merged commit f92d4fe into lenskit:main Jun 10, 2024
35 of 37 checks passed
@mdekstrand mdekstrand deleted the feature/mono-implicit branch June 10, 2024 20:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
components LensKit recommendation components
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

1 participant