Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Split FunkSVD into separate package in a monorepo #418

Merged
merged 54 commits into from
Jun 6, 2024

Conversation

mdekstrand
Copy link
Member

This addresses #378 by moving FunkSVD into a separate package, also laying the groundwork for #387. Closes #378.

@mdekstrand mdekstrand added the build Build, test, and platform support label Jun 6, 2024
@mdekstrand mdekstrand added this to the 2024.1 milestone Jun 6, 2024
@mdekstrand mdekstrand self-assigned this Jun 6, 2024
Copy link

codecov bot commented Jun 6, 2024

Codecov Report

Attention: Patch coverage is 62.96296% with 10 lines in your changes missing coverage. Please review.

Project coverage is 91.34%. Comparing base (2d39bd6) to head (2b184cb).
Report is 683 commits behind head on main.

Files with missing lines Patch % Lines
lenskit/lenskit/datasets/fetch.py 0.00% 7 Missing ⚠️
lenskit/lenskit/parallel/config.py 72.72% 3 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #418      +/-   ##
==========================================
+ Coverage   90.47%   91.34%   +0.87%     
==========================================
  Files          48       48              
  Lines        3201     3200       -1     
==========================================
+ Hits         2896     2923      +27     
+ Misses        305      277      -28     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@mdekstrand mdekstrand marked this pull request as ready for review June 6, 2024 18:32
@mdekstrand mdekstrand merged commit 2b184cb into lenskit:main Jun 6, 2024
26 of 27 checks passed
@mdekstrand mdekstrand deleted the feature/378-funksvd-split branch June 6, 2024 18:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
build Build, test, and platform support
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

Move FunkSVD to separate package
1 participant