Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Cython build infra + initial extension module #365

Closed
wants to merge 19 commits into from

Conversation

mdekstrand
Copy link
Member

This adds support for building extension modules with Cython, and uses it to implement a Cython-based kvp. This lays the groundwork for remaining work for #338.

@mdekstrand mdekstrand added the build Build, test, and platform support label Mar 3, 2024
@mdekstrand mdekstrand added this to the 2024.1 milestone Mar 3, 2024
@mdekstrand mdekstrand force-pushed the feature/cython-base branch from 085f390 to f8344b9 Compare March 4, 2024 00:00
Copy link

codecov bot commented Mar 4, 2024

Codecov Report

Attention: Patch coverage is 92.85714% with 6 lines in your changes are missing coverage. Please review.

Project coverage is 91.05%. Comparing base (2580591) to head (daab9c3).
Report is 10 commits behind head on main.

❗ Current head daab9c3 differs from pull request most recent head a9b39a1. Consider uploading reports for the commit a9b39a1 to get more accurate results

Files Patch % Lines
lenskit/util/kvp.pyx 92.85% 5 Missing ⚠️
lenskit/util/csmatrix.pyx 92.85% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #365      +/-   ##
==========================================
+ Coverage   91.00%   91.05%   +0.04%     
==========================================
  Files          40       42       +2     
  Lines        3125     3209      +84     
==========================================
+ Hits         2844     2922      +78     
- Misses        281      287       +6     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@mdekstrand mdekstrand marked this pull request as draft March 4, 2024 02:31
@mdekstrand mdekstrand force-pushed the feature/cython-base branch from 2bc8267 to 32c9914 Compare March 6, 2024 15:11
@mdekstrand mdekstrand force-pushed the feature/cython-base branch from daab9c3 to a9b39a1 Compare April 16, 2024 23:32
@mdekstrand mdekstrand closed this May 6, 2024
@mdekstrand mdekstrand deleted the feature/cython-base branch May 6, 2024 16:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
build Build, test, and platform support
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant