Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use threadpoolctl for debug checks #348

Merged
merged 5 commits into from
Nov 11, 2023

Conversation

mdekstrand
Copy link
Member

This uses threadpoolctl instead of our own cffi work to detect threading errors.

@mdekstrand mdekstrand added the internals Internal infrastructure (parallelism, math, etc.) label Nov 11, 2023
@mdekstrand mdekstrand added this to the 0.15.0 milestone Nov 11, 2023
return guess_blas_windows()
else:
return guess_blas_unix()
blas = BlasInfo(pool['internal_api'], pool.get('threading_layer', None), pool.get('num_threads', None), pool['version'])
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Line too long (128 > 100 characters)

Copy link

codeclimate bot commented Nov 11, 2023

Code Climate has analyzed commit bffdc00 and detected 3 issues on this pull request.

Here's the issue category breakdown:

Category Count
Complexity 1
Style 2

View more on Code Climate.

Copy link

codecov bot commented Nov 11, 2023

Codecov Report

Attention: 4 lines in your changes are missing coverage. Please review.

Comparison is base (18e224f) 90.16% compared to head (bffdc00) 90.99%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #348      +/-   ##
==========================================
+ Coverage   90.16%   90.99%   +0.82%     
==========================================
  Files          41       41              
  Lines        3234     3119     -115     
==========================================
- Hits         2916     2838      -78     
+ Misses        318      281      -37     
Files Coverage Δ
lenskit/util/parallel.py 96.40% <100.00%> (+0.95%) ⬆️
lenskit/util/debug.py 76.19% <83.33%> (+4.62%) ⬆️

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@mdekstrand mdekstrand merged commit bffdc00 into lenskit:main Nov 11, 2023
15 of 16 checks passed
@mdekstrand mdekstrand deleted the feature/debug-improve branch November 11, 2023 20:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
internals Internal infrastructure (parallelism, math, etc.)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant