Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use Pyproject2Conda to manage build envs #345

Merged
merged 13 commits into from
Nov 11, 2023
Merged

Conversation

mdekstrand
Copy link
Member

This switches our build environment management from conda-lock to pyproject2conda, with pre-rendered environment files saved in the envs dir. Closes #340.

@mdekstrand mdekstrand added the build Build, test, and platform support label Nov 10, 2023
@mdekstrand mdekstrand added this to the 0.15.0 milestone Nov 10, 2023
Copy link

codeclimate bot commented Nov 11, 2023

Code Climate has analyzed commit 8c873b2 and detected 14 issues on this pull request.

Here's the issue category breakdown:

Category Count
Style 14

View more on Code Climate.

Copy link

codecov bot commented Nov 11, 2023

Codecov Report

Attention: 32 lines in your changes are missing coverage. Please review.

Comparison is base (f2205fc) 91.08% compared to head (8c873b2) 89.98%.
Report is 11 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #345      +/-   ##
==========================================
- Coverage   91.08%   89.98%   -1.11%     
==========================================
  Files          39       41       +2     
  Lines        3187     3234      +47     
==========================================
+ Hits         2903     2910       +7     
- Misses        284      324      +40     
Files Coverage Δ
lenskit/datasets/__init__.py 100.00% <100.00%> (ø)
lenskit/datasets/movielens.py 69.23% <100.00%> (ø)
lenskit/util/__init__.py 87.14% <100.00%> (+2.14%) ⬆️
lenskit/datasets/fetch.py 27.27% <27.27%> (ø)

... and 2 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@mdekstrand mdekstrand merged commit 8c873b2 into lenskit:main Nov 11, 2023
14 of 16 checks passed
@mdekstrand mdekstrand deleted the tweak/p2c branch November 11, 2023 20:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
build Build, test, and platform support
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Migrate LensKit to P2C
1 participant